Fix bug when process OOMs due to retained LimitableRequestPublishers in RSocketServer #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mostroverkhov
force-pushed
the
bugfix/cleanup-on-cancel
branch
4 times, most recently
from
c9da160 to
b55aac5
Compare
smaldini
reviewed
May 21, 2019
| @@ -114,6 +118,9 @@ public static TcpServerTransport create(TcpServer server) { | |||
| acceptor.apply(connection).then(Mono.<Void>never()).subscribe(c.disposeSubscriber()); | |||
| }) | |||
| .bind() | |||
| .doOnNext( | |||
There was a problem hiding this comment.
Do we need to do that ? I'm wondering because we are opening the door to a new way to retain channels:
- Is there a use case where the server life is shorter than the application life ?
- If so, should we just shutdown event loops to force channels to be closed ?
- Is this related at all to the OOM since this is only doing anything when the server is closed ?
There was a problem hiding this comment.
@smaldini This is not related to OOM - just annoying bug living in reactor-netty for almost year, getting in a way when debugging. This change is my interpretation of what suggested as workaround by violeta at the bottom of reactor/reactor-netty#495. If I close Rsocket's server CloseableChannel, I d expect connections -> rsockets are closed aswell. The reason many changes are squashed in PR is there exist long-running soak test, and we would like to run It fewer times for this release
mostroverkhov
force-pushed
the
bugfix/cleanup-on-cancel
branch
from
b55aac5 to
59f3dd8
Compare
…cuted only on BaseSubscriber.cancel() Signed-off-by: Maksym Ostroverkhov <[email protected]>
…sableChannel close Signed-off-by: Maksym Ostroverkhov <[email protected]>
…andler Signed-off-by: Maksym Ostroverkhov <[email protected]>
Signed-off-by: Maksym Ostroverkhov <[email protected]>
Signed-off-by: Maksym Ostroverkhov <[email protected]>
Signed-off-by: Maksym Ostroverkhov <[email protected]>
remove rsocket-transport request coordination tests Signed-off-by: Maksym Ostroverkhov <[email protected]>
Signed-off-by: Maksym Ostroverkhov <[email protected]>
…on DisposableChannel close" This reverts commit 67bea79 Signed-off-by: Maksym Ostroverkhov <[email protected]>
mostroverkhov
force-pushed
the
bugfix/cleanup-on-cancel
branch
from
59f3dd8 to
ea266c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.